test: cuda integration tests #3065
Conversation
|
I want you to be aware that I removed two kernel-test-data.json tests in 2bcb015 (#3064 (comment)) because they were failing—that's probably important. Does the |
There was a problem hiding this comment.
I ran all the new tests, and they all work on my GPU.
====================== test session starts =======================
platform linux -- Python 3.10.14, pytest-8.1.1, pluggy-1.4.0
Matplotlib: 3.8.3
Freetype: 2.12.1
rootdir: /home/jpivarski/irishep/awkward
configfile: pyproject.toml
plugins: forked-1.6.0, typeguard-4.2.1, xdist-3.5.0, reverse-1.7.0, mpl-0.17.0, mock-3.14.0, timeout-2.2.0, cov-5.0.0, anyio-4.3.0
collected 463 items
tests-cuda/test_1276_cuda_num.py ......... [ 1%]
tests-cuda/test_1276_cuda_transfers.py ................ [ 5%]
tests-cuda/test_1276_cupy_interop.py . [ 5%]
tests-cuda/test_1276_from_cupy.py ..... [ 6%]
tests-cuda/test_1300_same_for_numba_cuda.py .............. [ 9%]
......... [ 11%]
tests-cuda/test_1381_check_errors.py . [ 11%]
tests-cuda/test_1809_array_cuda_jit.py .............. [ 14%]
tests-cuda/test_2922a_new_cuda_kernels.py ................ [ 18%]
...................................................... [ 30%]
tests-cuda/test_2922b_new_cuda_kernels.py ................ [ 33%]
............. [ 36%]
tests-cuda/test_3065a_cuda_kernels.py .................... [ 40%]
.......................................................... [ 53%]
.......................................................... [ 65%]
.......................................................... [ 78%]
......................................... [ 87%]
tests-cuda/test_3065b_cuda_kernels.py .................... [ 91%]
.... [ 92%]
tests-cuda/test_3065c_cuda_kernels.py .................... [ 96%]
................ [100%]
====================== 463 passed in 12.90s ======================
(as well as all the kernel unit tests). I have some questions below, but no complaints. Go ahead and merge this PR whenever you're ready!
src/awkward/_connect/cuda/cuda_kernels/awkward_UnionArray_regular_index_getsize.cu
Show resolved
Hide resolved
@jpivarski The status flag turns off all the tests for a particular kernel. We can't turn off off a specific test with that. I saw your comment about that earlier. I checked and they were failing only for Python kernels. Were there any errors in the cuda tests too on your GPU? Due to the changes to promotion in Numpy 2.x, it gives |
Those tests are included in this branch, right? If so, then I have tested them on the GPU and they work.
That's very likely; we only saw this error when upgrading to NumPy 2.0. Since I had to get a version of Awkward out with NumPy 2.0 support, I had to drop the tests, but I didn't want them to get forgotten about. |
No, I meant the tests that were removed. As for me those tests were failing only for the Python kernel and not CPU and CUDA kernels.
I have opened up a issue #3071 and self- assigned it. I will fix it in the coming week! |
No description provided.